-
Notifications
You must be signed in to change notification settings - Fork 724
docs: Fix container destructuring #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you give some context to this statement? I could not find anything supporting that claim. |
@eps1lon Check npm last publish. |
Which is 0.3. Neither 0.3 nor https://www.npmjs.com/package/babel-plugin-react-remove-properties/ are marked as deprecated. Could you be more specific why you think that package is no longer maintained? |
I meant the last publish date which is March 2019! Also supporting active packages is encouraging for their maintainers. That's just my opinion! |
It didn't need one for over 2 years. That's a good sign. I looked at the repo and it has a single open issue. No open PRs. That's one of the cleanest states I've seen a repo in that didn't have an update in 2 years.
It also encourages maintainers to constantly re-publish their package just to stay relevant. Let's relieve maintainers of some pressure. I'm just speaking for myself here but I'm no looking forward to having all my packages replaced just because I didn't update needlessly.
"no longer maintained" and "deprecated" are very close concepts but I understand that this was putting words in your mouth. Still, not having received an update is not sufficient evidence that it's no longer maintained. Especially if said package didn't need maintenance. And I work with the author on other projects so I know he's still active. |
That's right.
Cool, I didn't know that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good fix, but we should probably rename the commit on merge
Nevermind, the PR was changed. |
@ErfanMirzapour Thanks! |
Doc page: (q4)
https://testing-library.com/docs/dom-testing-library/faq
The suggested plugin is no longer maintained.
Just changed it with newer/active one.
+Fix a syntax error in q5.